Add query table function for query pass-through to Cassandra connector#15973
Add query table function for query pass-through to Cassandra connector#15973ebyhr merged 3 commits intotrinodb:masterfrom
query table function for query pass-through to Cassandra connector#15973Conversation
ebyhr
force-pushed
the
ebi/cassandra-query-pass-through
branch
from
094257d to
9a6a0d4
Compare
There was a problem hiding this comment.
As a follow up - can we use assertJsonRoundTrip for testing these handles ?
|
Addressed comments. |
ebyhr
force-pushed
the
ebi/cassandra-query-pass-through
branch
from
650d3aa to
176e091
Compare
There was a problem hiding this comment.
no changes requested : Maybe as a followup - can we inline the method - we could do the cast operation in method which invokes this one.
There was a problem hiding this comment.
Can we use testTable so we don't have to have a dedicated query executor for cassandra and we don't have to drop the table.
There was a problem hiding this comment.
Note that TestCassandraTable doesn't support single column with primary key. Using onCassandra is simpler than TestCassandraTable style.
There was a problem hiding this comment.
In this case can we move dropping operations to finally block ?
There was a problem hiding this comment.
Since we use onCassandra at a some places - Can we add support for TestCassandraTable with a single column primary key ?
There was a problem hiding this comment.
Let me handle in follow-up PR.
There was a problem hiding this comment.
What is your opinion on returning as CassandraNamedRelationHandle ?
There was a problem hiding this comment.
Could you elaborate on that?
There was a problem hiding this comment.
Currently CassandraTable has two fields - CassandraTableHandle and List<CassandraColumnHandle. CassandraTableHandle is wrapper for both named and query based relation - which might be an overkill here. Instead can we have something like this
public CassandraTable(CassandraNamedRelationHandle tableHandle, List<CassandraColumnHandle> columns)
Just thinking out aloud.
ebyhr
force-pushed
the
ebi/cassandra-query-pass-through
branch
from
176e091 to
45cb706
Compare
|
Addressed comments. |
|
I found a correctness issue when duplicated columns exist with different cases. e.g. col & COL. I'm fixing the issue now. |
This is needed for upcoming query pass-through function.
ebyhr
force-pushed
the
ebi/cassandra-query-pass-through
branch
from
45cb706 to
38fb388
Compare
Praveen2112
left a comment
Praveen2112
left a comment
There was a problem hiding this comment.
LGTM. Minor comments. Thanks for working on this.
There was a problem hiding this comment.
Currently CassandraTable has two fields - CassandraTableHandle and List<CassandraColumnHandle. CassandraTableHandle is wrapper for both named and query based relation - which might be an overkill here. Instead can we have something like this
public CassandraTable(CassandraNamedRelationHandle tableHandle, List<CassandraColumnHandle> columns)
Just thinking out aloud.
There was a problem hiding this comment.
In this case can we move dropping operations to finally block ?
There was a problem hiding this comment.
Since we use onCassandra at a some places - Can we add support for TestCassandraTable with a single column primary key ?
ebyhr
force-pushed
the
ebi/cassandra-query-pass-through
branch
from
38fb388 to
f825e49
Compare
2 participants
Description
Add
querytable function for query pass-through to Cassandra connectorRelease notes
(x) Release notes are required, with the following suggested text: